Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-111178: Generate correct signature for self converters #128447

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 3, 2025

@erlend-aasland

This comment was marked as resolved.

@erlend-aasland
Copy link
Contributor Author

WDYT, @picnixz?

@picnixz
Copy link
Contributor

picnixz commented Jan 3, 2025

I think this is what I had in mind. I'm no more on my dev session but I'll pick your branch, create a branch with all my known UBSan fixes branches and then I'll need to manually address the remaining ones.

AFAICT, no new _impl functions were added so performances shouldn't be affected I think? (it's only pointer casts for the compiler). I'll review more in details tomorrow but thank you for the work!

@erlend-aasland
Copy link
Contributor Author

Yeah, this PR only makes sure we're using PyObject pointers in the PyMethodDef "entries". No new [clinic input] sections, no new _impl functions. Performance should not be affected.

@erlend-aasland
Copy link
Contributor Author

I'll leave this in draft so we don't create a review rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants