Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added enfageorge to list #26

Closed
wants to merge 10 commits into from
Closed

Conversation

enfageorge
Copy link

No description provided.

@datapythonista
Copy link
Member

Good job @enfageorge. Do you mind in a separate PR to change the title of the page? May be you can find us a good name?

@enfageorge
Copy link
Author

Good job @enfageorge. Do you mind in a separate PR to change the title of the page? May be you can find us a good name?

I'll take suggestions from the team and do that as soon as we fix on one.

@sparalic
Copy link
Member

@enfageorge—> Pandanistas

@datapythonista
Copy link
Member

pandas girls or pydata girls are not very original, but I guess you're aware of https://djangogirls.org/ ;)

@datapythonista
Copy link
Member

and you surely know https://www.pyladies.com/

@datapythonista
Copy link
Member

@enfageorge we will go back to the name later, can you for now just remove the Mentoring in the title, and just leave New pandas contributors (team 2019) please? In a new PR.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this looks great now.

Can you work on #26 (comment) before I merge please?

Enfa Rose George and others added 2 commits July 31, 2019 21:52
@datapythonista
Copy link
Member

Thanks! Do you mind making the change to the title in a new PR, and leaving here only the addition of your name? Sorry if it sounds silly, but in general in open source every PR addresses one and only one thing.

@enfageorge
Copy link
Author

enfageorge commented Jul 31, 2019

Sorry, just figuring out things. Now this PR has just addition of my name in it.

Enfa Rose George and others added 2 commits July 31, 2019 22:13
@enfageorge
Copy link
Author

I just realized that I have made changes to my master and put PR from it. I would like to put both changes in separate branches and put separate PR. Closing this PR.

@enfageorge enfageorge closed this Jul 31, 2019
@enfageorge
Copy link
Author

Added my username in #65 and changed the title in #66. I hope all is good now

@sara-02
Copy link
Member

sara-02 commented Jul 31, 2019

@enfageorge kudos. Yes, both the PRs are correctly put :)

@enfageorge enfageorge mentioned this pull request Jul 31, 2019
@datapythonista
Copy link
Member

@enfageorge this was closed, and no name was selected for the team. May be you can create an issue to keep that discussion open?

@enfageorge
Copy link
Author

@datapythonista done in #80 just now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants