-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClockEventLoop class with fixture and test (close #95) #96
Closed
derekbrokeit
wants to merge
16
commits into
pytest-dev:master
from
derekbrokeit:add-clock-event-loop
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
71701e1
Add ClockEventLoop class with fixture and test (close #95)
derekbrokeit 3d34037
add doc string to ClockEventLoop
derekbrokeit a723020
improve name of nap function in test_clock_loop
derekbrokeit 997afe2
fix ClockEventLoop being a selector loop, instead use default of asyncio
derekbrokeit 6fbeb60
refactor ClockEventLoop to only advance time but otherwise act as sta…
derekbrokeit 7d94f14
add asyncio_clock mark so that coroutines can be run in a ClockEventL…
derekbrokeit 8841d15
fix test_clock_advance_time for changes to ClockEventLoop interface
derekbrokeit 98c6bf8
add simple tests for asyncio_clock mark and clock_event_loop fixture
derekbrokeit d757d19
Merge remote-tracking branch 'remotes/base/master' into add-clock-eve…
derekbrokeit ce6a2c7
rearrange ClockEventLoop.advance_time so that extra iterations are no…
derekbrokeit 1a8b887
calls to asyncio.sleep in ClockEventLoop force the sleeping loop
derekbrokeit f3efb64
remove ValueError from ClockEventLoop.advance_time in favor of return…
derekbrokeit 8452d41
Fixes for given questions posed
derekbrokeit 559e883
further simplify advance_time method
derekbrokeit 1d3cd51
rework advance_time to reduce complexity
derekbrokeit ed8b05d
make the clock_event_loop test easier to read
derekbrokeit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make test reliable I tend to await explicitly:
(and change short_nap/advance to 10)
I do this because though advance_time marks task's sleep as finished, but the exact number of event loop iterations between this and the actual closing of the task is implementation-dependent.