-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial (and shallow) clone note #1611
base: main
Are you sure you want to change the base?
Conversation
Add note about partial and shallow clone, with external link describing them in detail. Signed-off-by: Bagas Sanjaya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have more suggestions coming up, but first follow the "one sentence per line" structure.
From @HonkingGoose: * Split paragraphs into one sentence each line Co-authored-by: HonkingGoose <[email protected]>
review ping |
Rewording from @HonkingGoose Co-authored-by: HonkingGoose <[email protected]>
review ping |
I have two minds on this PR. On the one hand, it's well-written, and valuable info for the reader. But does it belong in chapter 2? This is where a reader who has never worked with Git before gets their first taste. We deliberately prioritize that first-time experience in this chapter over things like absolute correctness or deep-dives into topics. It seems to me that this content would be a better fit as a section in chapter 7, where there's some room to dig into some common use cases. Would you want to take a swing at that larger chunk of content? |
@ben ok |
Changes
Add note about partial and shallow clone, with external link describing
them in detail. The note is in Chapter 2 - Getting a repository
Context
Fixes #1597