Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore(Select): Remove CSS modules feature flag from Select" #5497

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Revert "chore(Select): Remove CSS modules feature flag from Select" #5497

merged 2 commits into from
Jan 6, 2025

Conversation

francinelucca
Copy link
Member

Reverts #5464

Flag is being moved to ga in #5439, we're pushing this change to a release further down

@francinelucca francinelucca requested a review from a team as a code owner January 6, 2025 17:09
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f81f82c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jan 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 6, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5497 January 6, 2025 17:11 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.59 KB (-0.34% 🔽)
packages/react/dist/browser.umd.js 103.93 KB (-0.32% 🔽)

@francinelucca francinelucca added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 586083a Jan 6, 2025
42 checks passed
@francinelucca francinelucca deleted the revert-5464-css_modules_remove_select branch January 6, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francinelucca @jonrohan