Export things we need for CommentEditor #4513
Conversation
🦋 Changeset detectedLatest commit: 8fe6af5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
owenniblock
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
|
Related / similar PR: #4504 |
owenniblock
temporarily deployed
to
github-pages
GitHub Actions
Inactive
| @@ -45,6 +45,10 @@ export {useRefObjectAsForwardedRef} from './hooks/useRefObjectAsForwardedRef' | |||
| export {useResizeObserver} from './hooks/useResizeObserver' | |||
| export {useResponsiveValue} from './hooks/useResponsiveValue' | |||
|
|
|||
| // Utils | |||
| export {createComponent} from './utils/create-component' | |||
There was a problem hiding this comment.
For stability, is this something that we feel like will be stable/unlikely to change without a breaking change or would it be helpful to have a "bake period" in drafts/experimental before promoting to stable?
Wasn't sure about the status of the helper and wanted to check-in 👍 Totally understand either way.
There was a problem hiding this comment.
It'll likely be removed when we upgrade to React 19. In lieu of that I think any changes can happen alongside major releases. I don't anticipate huge changes.
* Export things we need for CommentEditor * Add changeset * Update snapshot * Remove ComponentProps export and use React.ComponentProps in dotcom * Remove the bits of ComponentProps
Because we're housing the MarkdownToolbar in dotcom, we need to export a couple of things that we use there.
Changelog
New
Exports
createComponentChanged
Removed
Rollout strategy
Testing & Reviewing
Merge checklist