Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Specify execa devDep #555

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

rschristian
Copy link
Member

execa is used as part of the test suite, and while not specifying it doesn't immediately cause problems here, it is tripping up the ecosystem-ci I'm writing. This seemed like a reasonable enough of a thing to correct, however, as right now the test suite is relying on transient copies of execa to be lying around for use.


Essentially, as execa is not specified as a dependency, pnpm is able to resolve it from other places outside of the prefresh project (depending on directory structure and whatnot). execa is a Sindre package that went ESM-only in v6, so pulling anything newer obviously chokes up the require()s used here. Explicitly specifying it corrects pnpm's resolution, ensuring we only use a compatible v5.

Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: 06bd1d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rschristian rschristian force-pushed the chore/specify-execa-devDep branch from e15cb16 to 06bd1d7 Compare September 27, 2024 07:28
@JoviDeCroock JoviDeCroock merged commit d127aef into main Sep 27, 2024
1 check passed
@JoviDeCroock JoviDeCroock deleted the chore/specify-execa-devDep branch September 27, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants