Fixes hash_function and error handler missing call for multi #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marthacryan can you please review? |
|
When I try to follow the link for #1885, it gives me a "Page not found" error. Is that because of permissions? Was it deleted? |
|
that is strange - @T4rk1n any ideas? |
|
@T4rk1n , could you apply the try-except logic from https://github.com/plotly/dash/blob/dev/dash/long_callback/managers/__init__.py#L110 to https://github.com/plotly/dash/blob/dev/dash/long_callback/managers/__init__.py#L58 as well? In the current situation, long callbacks still fail for packed applications (eg. Pyinstaller). Fixing this would close Nuitka/Nuitka#2988 as well. Edit: opened PR #3072 for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoUpdate()for multi output callbacks error handler.