Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/cmd: added operator checksum-as|force-flush #58801

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Jan 8, 2025

What problem does this PR solve?

Issue Number: close #58798 #58799

Problem Summary:
See the issue description.

What changed and how does it work?

This PR added two new subcommands to br operator:

checksum-as: this generates rewrite rule from a storage and performs checksum.
force-flush: this allows user to force trigger a flush.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    I used these utilities when executing some internal tests. They works fine as far as I go.
    The scenarios including:
  1. Checksum in a cluster with log backup enabled. (Upstream)
  2. Restore point in a new cluster. (Downstream)
  3. Run checksum-as where -s is the --full-backup-storage in the restore point command.
  4. Compare the checksum.

(With the compatibility solution between log backup and ingesting, which doesn't present in master branch yet)

  1. Run checksum-as after restoring to a cluster, where -s is the restored backup.
  2. After a point in time restore to another cluster, run checksum-as over the tables restored where -s is the restored backup in 1..

The force-flush part was used in integration tests.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 8, 2025
@YuJuncen YuJuncen changed the title added operator checksum-as|force-flush br/cmd: added operator checksum-as|force-flush Jan 8, 2025
Copy link

ti-chi-bot bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yujuncen, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

tiprow bot commented Jan 8, 2025

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 25.49020% with 228 lines in your changes missing coverage. Please review.

Project coverage is 74.6760%. Comparing base (9d0fb30) to head (15664c5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58801        +/-   ##
================================================
+ Coverage   73.1094%   74.6760%   +1.5665%     
================================================
  Files          1676       1693        +17     
  Lines        463866     464260       +394     
================================================
+ Hits         339130     346691      +7561     
+ Misses       103877      95949      -7928     
- Partials      20859      21620       +761     
Flag Coverage Δ
integration 45.9989% <25.4902%> (?)
unit 72.2913% <10.1307%> (-0.0271%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.3763% <25.4902%> (+15.6313%) ⬆️

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Jan 9, 2025

/retest-required

Copy link

tiprow bot commented Jan 9, 2025

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: hillium <[email protected]>
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Jan 9, 2025

/retest-required

Copy link

tiprow bot commented Jan 9, 2025

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Jan 9, 2025

merge: 476f860c09e8b068b9b5ebffc2bf28a134bfa221 - not something we can merge ...?

/test build

Copy link

tiprow bot commented Jan 9, 2025

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

merge: 476f860c09e8b068b9b5ebffc2bf28a134bfa221 - not something we can merge ...?

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Jan 9, 2025

/test build

Copy link

tiprow bot commented Jan 9, 2025

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YuJuncen YuJuncen closed this Jan 9, 2025
@YuJuncen YuJuncen reopened this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br/operator: add new command for run checksumming
1 participant