Upgrade Pico 2.1 to PHP 8.2/8.3 #706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Croydon
reviewed
Oct 23, 2024
Agreed. Release more often with small changes is much better. |
Make Pico compatible with PHP 8.2 and 8.3. - Upgrade symfony/yaml config reader - Upgrade twig template engine, - Raise supported PHP version, - Remove pico/pico-deprecated - Remove redundant index files - Use pico-composer to set up a project Required Changes for users running version 2.1: - Replace composer.json from pico/pico-composer to load Pico Core via Composer - Add all required folders to project root (config/, plugins/, themes/) - Convert config file from PHP to YAML - Errors may happen due to wrong value types (eg. multiline text is not supported) - Themes may need some tweaks: - Themes need a YAML config as well - HTML files in themes need to be renamed to TWIG files - Replace twig condition »is_front_page« with »current_page.id == "index"« - Replace twig variable »page.excerpt« with »page.meta.Summary«
pixelbrackets
force-pushed
the
php8-update
branch
from
d4324bb to
347bb91
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
please merge and I can then test the upgrade |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Since this ticket bot creates a reminder every few days: @PhrozenByte, I wrote you an e-mail a while ago concerning the Pico project. Would be cool to get in touch and discuss an idea how to resolve the stale condition. Best regards. Dan |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a Pico 2.1 instance compatible with PHP 8.2 and 8.3.
Notable changes:
Required changes for users running version 2.1:
config/,plugins/,themes/)Thats it, Pico runs smoth again with PHP 8.2 and 8.3. 🎉
🍫 Pico is a super nice project, dead simple to use and with a small footprint. It is stared and used by many, many developers. Unfortunately it ran into a feature creep during development of not one but two new versions, which resulted the project to appear abondoned. My proposal: if possible; merge this PR and tag a new version for people to use.
Cancel the discussions about new versions, hide the development branches mentally and formally (individual ideas can always be taken up again) and releases a simple upgrade version instead.