Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravity update: Handle color escape sequences #3191

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

catch-error
Copy link

What does this PR aim to accomplish?:

Currently when running gravity update, the color escape sequences used by the shell script are printed literally on the web gui:

  [�[1;32m✓�[0m] DNS resolution is available

  [i] Neutrino emissions detected�[0m...
  [�[1;32m✓�[0m] Pulling blocklist source list into range
  ...

This should be the matching real colors instead.

How does this PR accomplish the above?:

The patch checks each line fragment for the existance of a pattern that represents an (ANSI) color code escape sequence and substitutes it with a fitting HTML code.

To preserve color coding also when removing line(s) because of OVER escape sequences, the code is changed from using .text() to .html().

Link documentation PRs if any are needed to support this PR:

N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser
Copy link
Member

yubiuser commented Jan 7, 2025

Interesting, what browser do you use?
I don't see colors, but the escape sequences are printed as they should as symbols.

@rdwebdesign
Copy link
Member

rdwebdesign commented Jan 7, 2025

I just checked and also don't see color codes.
I think they should be stripped before data is sent to the browser. Actually this is how v5 works.

@catch-error
Copy link
Author

I tried it on Chrome & Safari on MacOS, Chrome & Firefox and Windows & Linux. Some subtle differences how the actual escape character is printed, but the rest looks pretty much the same on all systems. I have been working with 6.0 code a lot lately, so maybe screwed something up on my DEV VM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants