Improve custom DNS hosts file parsing #3103
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Improve parsing of custom DNS hosts file. This is useful when directly importing an existing hosts file in to pihole, which may contain comments or variable whitespace.
This allows entries with variable whitespace to appear in the web interface.
How does this PR accomplish the above?:
Modify parsing code to allow variable whitespace, and exclude comments
Link documentation PRs if any are needed to support this PR:
n/a
By submitting this pull request, I confirm the following:
git rebase
)