Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rev-server crash #2010

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fix rev-server crash #2010

merged 1 commit into from
Jul 15, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 15, 2024

What does this implement/fix?

Fix crash caused by double free() corruption encountered with rev-server addresses with prefix lengths != {8,16,24,32}.

The patch submitted upstream is tracked here: pi-hole/dnsmasq#15

We decide to merge this change now as nothing at all has happened on the mailing list for months by now and users came and asked for the status of our bug fix.


Related issue or feature (if applicable): https://discourse.pi-hole.net/t/todays-update-kills-pihole-v6/70739

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…ver addresses with prefix lengths != {8,16,24,32}

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER added Bugfix dnsmasq bug Bug:Discourse Bug reported on Discourse forum labels Jul 15, 2024
@DL6ER DL6ER requested a review from a team July 15, 2024 05:52
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/todays-update-kills-pihole-v6/70739/14

@DL6ER DL6ER changed the title Fix crash caused by double free() corruption encountered with rev-ser… Fix rev-server crash Jul 15, 2024
@yubiuser yubiuser merged commit f12d14f into development-v6 Jul 15, 2024
16 checks passed
@yubiuser yubiuser deleted the fix/rev-servers-crash branch July 15, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:Discourse Bug reported on Discourse forum Bugfix dnsmasq bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants