Inspect columns in embeddables

phpstan · Jan 28, 2020 · b99ae3d · b99ae3d
1 parent 77d3d8e
commit b99ae3d
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 3 deletions.
diff --git a/src/Rules/Doctrine/ORM/EntityColumnRule.php b/src/Rules/Doctrine/ORM/EntityColumnRule.php
@@ -68,9 +68,6 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$className = $class->getName();
-		if ($objectManager->getMetadataFactory()->isTransient($className)) {
-			return [];
-		}
 
 		try {
 			$metadata = $objectManager->getClassMetadata($className);

diff --git a/tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php b/tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php
@@ -168,6 +168,21 @@ public function testEmbeddedWithWrongTypeHint(): void
 		]);
 	}
 
+	public function testEmbeddable(): void
+	{
+		$this->analyse([__DIR__ . '/data/Embeddable.php'], []);
+	}
+
+	public function testBrokenEmbeddable(): void
+	{
+		$this->analyse([__DIR__ . '/data/BrokenEmbeddable.php'], [
+			[
+				'Property PHPStan\Rules\Doctrine\ORM\BrokenEmbeddable::$one type mapping mismatch: database can contain string|null but property expects string.',
+				16,
+			],
+		]);
+	}
+
 	public function testUnknownType(): void
 	{
 		$this->analyse([__DIR__ . '/data/EntityWithUnknownType.php'], [

diff --git a/tests/Rules/Doctrine/ORM/data/BrokenEmbeddable.php b/tests/Rules/Doctrine/ORM/data/BrokenEmbeddable.php
@@ -0,0 +1,17 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Embeddable()
+ */
+class BrokenEmbeddable
+{
+	/**
+	 * @ORM\Column(type="string", nullable=true)
+	 * @var string
+	 */
+	private $one;
+}