Update list.html

[VenkateshThoguta]

Updated class of about section by adding f4

[juliaferraioli]

This is a great start! Can you refer back to this issue comment for other areas that need fixing as well? If you look through the various pages/layouts, you can see similar inconsistencies.

[VenkateshThoguta]

What changes actually need to be done? There is only Font size and color issue

…

On Tue, 20 Jun 2023, 22:11 julia ferraioli, ***@***.***> wrote: ***@***.**** requested changes on this pull request. This is a great start! Can you refer back to this issue comment <#49 (comment)> for other areas that need fixing as well? If you look through the various pages/layouts, you can see similar inconsistencies. — Reply to this email directly, view it on GitHub <#99 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5R57DWBDJ6A4M3MC6HUK4DXMHHCRANCNFSM6AAAAAAZNOPSUM> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

[juliaferraioli]

I linked the issue comment that specifies what needs done. You have modified one layout, but others likely need modification as well, including contribute/list.html and posts/list.html.

Copying from that:

If you look at the bio text on our about page, the font and font color isn't set to what we use in the text above it.

For the data rendering, we probably want the div to have almost-black added to the class:

opensourcestories.org/layouts/about/list.html

Line 15 in e5d960d

the h2 to have f3 fw1 lh-title added to the class:

opensourcestories.org/layouts/about/list.html

Line 16 in e5d960d

{{ .name }}, {{ .roles }}

and the p to have f5-l nested-copy-line-height added to the class:

opensourcestories.org/layouts/about/list.html

Line 17 in e5d960d

{{ .bio }}

[VenkateshThoguta]

Thanks, I'll take a look.

…

On Thu, 22 Jun 2023, 21:55 julia ferraioli, ***@***.***> wrote: I linked the issue comment that specifies what needs done. You have modified one layout, but others likely need modification as well, including contribute/list.html <https://github.com/opensourcestories/opensourcestories.org/blob/main/layouts/contribute/list.html> and posts/list.html <https://github.com/opensourcestories/opensourcestories.org/blob/main/layouts/posts/list.html> . Copying from that: If you look at the bio text on our about page <https://www.opensourcestories.org/about/>, the font and font color isn't set to what we use in the text above it. For the data rendering, we probably want the div to have almost-black added to the class: opensourcestories.org/layouts/about/list.html <https://github.com/opensourcestories/opensourcestories.org/blob/e5d960d8fd5884dc751a07987019980c37923fc9/layouts/about/list.html#L15> Line 15 in e5d960d <e5d960d> the h2 to have f3 fw1 lh-title added to the class: opensourcestories.org/layouts/about/list.html <https://github.com/opensourcestories/opensourcestories.org/blob/e5d960d8fd5884dc751a07987019980c37923fc9/layouts/about/list.html#L16> Line 16 in e5d960d <e5d960d> {{ .name }}, {{ .roles }} and the p to have f5-l nested-copy-line-height added to the class: opensourcestories.org/layouts/about/list.html <https://github.com/opensourcestories/opensourcestories.org/blob/e5d960d8fd5884dc751a07987019980c37923fc9/layouts/about/list.html#L17> Line 17 in e5d960d <e5d960d> {{ .bio }} — Reply to this email directly, view it on GitHub <#99 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5R57DREFPEGB7P46WFMBB3XMRWW7ANCNFSM6AAAAAAZNOPSUM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.