Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add build and test docs for all mayastor repos #1783

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tiagolobocastro
Copy link
Contributor

No description provided.

@maxwnewcomer
Copy link
Contributor

Thank you so much for putting this together, cleared up a lot of questions I've had.

@tiagolobocastro
Copy link
Contributor Author

Thank you so much for putting this together, cleared up a lot of questions I've had.

Thanks @maxwnewcomer, I'm glad this helps!
Let us know if there's anything else we could improve on

Something that could be interesting is how to cross-compile for ARM from x86.
The kubectl-mayastor plugin is currently cross-compiled for ARM.
It does take an awful lot of time though: https://github.com/openebs/mayastor-extensions/actions/runs/12351790197/job/34467462887
Though I'm not sure why, I suspect caching may not be working quite correctly on the github actions.

io-engine-1 10.1.0.5:10124 Online v1.0.0-997-g17488f4a7da3
```

You can also use the swagger-ui available on the [localhost:8081](http://localhost:8081/v0/swagger-ui#).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can mention here that port forwarding may be required to use swagger UI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you thinking of K8s?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it depends where deployer is started. e.g typically if started in a VM that we ssh into, then have to port forward between local machine and VM. e.g
ssh -L 8081:127.0.0.1:8081 username@host

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone is starting it on a remote shell, then they should know they have to port-forward that, it won't magically appear on their hosts :)


Or, for ad-hoc:

- Ensure at least 512 2MB hugepages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we recommend minimum 1024 2MiB hugepages typically

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing docs mentions 512, so guess we should change it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Ensure at least 512 2MB hugepages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I wonder if actually neither is sufficient, some tests use a lot of IO engines and run IO.
Perhaps we ought to run the tests with 1024 and check if it's enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks like for testing you actually need 3584 for the rust tests and 2560 for the bdd tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants