Explicitly call PowerOnTask to allow DRS to function

lib/vSphere/action/clone.rb

@@ -29,7 +29,7 @@ def call(env)
             fail Errors::VSphereError, :'invalid_configuration_linked_clone_with_sdrs' if config.linked_clone && ds.is_a?(RbVmomi::VIM::StoragePod)
 
             location = get_location ds, dc, machine, template
-            spec = RbVmomi::VIM.VirtualMachineCloneSpec location: location, powerOn: true, template: false
+            spec = RbVmomi::VIM.VirtualMachineCloneSpec location: location, powerOn: false, template: false
             spec[:config] = RbVmomi::VIM.VirtualMachineConfigSpec
             customization_info = get_customization_spec_info_by_name connection, machine
 
@@ -83,13 +83,15 @@ def call(env)
 
               apply_sr_result = storage_mgr.ApplyStorageDrsRecommendation_Task(key: [key]).wait_for_completion
               new_vm = apply_sr_result.vm
+              new_vm.PowerOnVM_Task().wait_for_completion
 
             else
               env[:ui].info I18n.t('vsphere.creating_cloned_vm')
               env[:ui].info " -- #{config.clone_from_vm ? 'Source' : 'Template'} VM: #{template.pretty_path}"
               env[:ui].info " -- Target VM: #{vm_base_folder.pretty_path}/#{name}"
 
               new_vm = template.CloneVM_Task(folder: vm_base_folder, name: name, spec: spec).wait_for_completion
+              new_vm.PowerOnVM_Task().wait_for_completion
 
               config.custom_attributes.each do |k, v|
                 env[:ui].info "Setting custom attribute: #{k}=#{v}"

lib/vSphere/action/get_ssh_info.rb

@@ -24,6 +24,7 @@ def filter_guest_nic(vm, machine)
           interfaces = vm.guest.net.select { |g| g.deviceConfigId > 0 }
           ip_addresses = interfaces.map { |i| i.ipConfig.ipAddress.select { |a| a.state == 'preferred' } }.flatten
 
+          return nil if ip_addresses.empty?
           fail Errors::VSphereError.new, :'multiple_interface_with_real_nic_ip_set' if ip_addresses.size > 1
           ip_addresses.first.ipAddress
         end

spec/clone_spec.rb

@@ -15,6 +15,7 @@
       spec: { location: { pool: @child_resource_pool },
               config: RbVmomi::VIM.VirtualMachineConfigSpec }
     )
+    expect(@new_vm).to have_received :PowerOnVM_Task
   end
 
   it 'should create a CloneVM task with custom folder when given vm base path' do
@@ -29,6 +30,7 @@
       spec: { location: { pool: @child_resource_pool },
               config: RbVmomi::VIM.VirtualMachineConfigSpec }
     )
+    expect(@new_vm).to have_received :PowerOnVM_Task
   end
 
   it 'should set the machine id to be the new UUID' do
@@ -59,6 +61,7 @@
               config: expected_config
       }
     )
+    expect(@new_vm).to have_received :PowerOnVM_Task
   end
 
   it 'should create a CloneVM spec with configured memory_mb' do
@@ -70,6 +73,7 @@
       spec: { location: { pool: @child_resource_pool },
               config: RbVmomi::VIM.VirtualMachineConfigSpec(memoryMB: 2048) }
     )
+    expect(@new_vm).to have_received :PowerOnVM_Task
   end
 
   it 'should create a CloneVM spec with configured number of cpus' do
@@ -81,6 +85,7 @@
       spec: { location: { pool: @child_resource_pool },
               config: RbVmomi::VIM.VirtualMachineConfigSpec(numCPUs: 4) }
     )
+    expect(@new_vm).to have_received :PowerOnVM_Task
   end
 
   it 'should set static IP when given config spec' do
@@ -98,6 +103,7 @@
       spec: { location: { pool: @root_resource_pool },
               config: RbVmomi::VIM.VirtualMachineConfigSpec }
     )
+    expect(@new_vm).to have_received :PowerOnVM_Task
   end
 
   it 'should set extraConfig if specified' do
@@ -114,6 +120,7 @@
       spec: { location: { pool: @child_resource_pool },
               config: expected_config }
     )
+    expect(@new_vm).to have_received :PowerOnVM_Task
   end
 
   it 'should set custom notes when they are specified' do
@@ -125,5 +132,6 @@
       spec: { location: { pool: @child_resource_pool },
               config: RbVmomi::VIM.VirtualMachineConfigSpec(annotation: 'custom_notes') }
     )
+    expect(@new_vm).to have_received :PowerOnVM_Task
   end
 end

spec/get_ssh_info_spec.rb

@@ -116,6 +116,15 @@
         expect(@env[:machine_ssh_info][:host]).to eq IP_ADDRESS
       end
 
+      context 'when the VM networking is uninitialized' do
+        before do
+          allow(@vm.guest).to receive(:net) { [] }
+        end
+        it 'should set the ssh info to nil if no valid adapters are present' do
+          call
+          expect(@env[:machine_ssh_info]).to eq nil
+        end
+      end
     end
   end
 end

spec/spec_helper.rb

@@ -131,11 +131,15 @@ def call
     @template_config = double('template_config',
                               hardware: @virtual_hardware)
 
+    @new_vm = double('new_vm',
+                     config: double('config', uuid: NEW_UUID),
+                     PowerOnVM_Task: double('result', wait_for_completion: nil))
+
     @template = double('template_vm',
                        parent: @data_center,
                        pretty_path: "#{@data_center.pretty_path}/template_vm",
                        CloneVM_Task: double('result',
-                                            wait_for_completion: double('new_vm', config: double('config', uuid: NEW_UUID))),
+                                            wait_for_completion: @new_vm),
                        config: @template_config)
 
     @data_center.stub(:find_vm).with(TEMPLATE).and_return(@template)