Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(images): Build multi-arch images #658

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

SystemKeeper
Copy link
Contributor

@SystemKeeper SystemKeeper commented Aug 26, 2024

Example run with changed Dockerfile: https://github.com/nextcloud/docker-ci/actions/runs/12613287202/job/35150961232#step:3:207

All runners now support binfmt that is needed to build multi-arch images (that support was missing back in August when the PR was created).

@SystemKeeper SystemKeeper force-pushed the feat/noid/multi-arch-images branch 2 times, most recently from 832b55f to 5ee2447 Compare January 5, 2025 16:43
@SystemKeeper SystemKeeper force-pushed the feat/noid/multi-arch-images branch from 5ee2447 to 8d6d1e7 Compare January 5, 2025 16:51
@SystemKeeper SystemKeeper marked this pull request as ready for review January 5, 2025 16:54
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough to me, but I have no clue what it changes and why

@nickvergessen nickvergessen merged commit 1c795a9 into master Jan 8, 2025
4 checks passed
@nickvergessen nickvergessen deleted the feat/noid/multi-arch-images branch January 8, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants