Fix for inconsistent timezone handling #5931
Open
+579
−537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d9e4e3d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
darrellwarde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a potential fix for #3785. This is a hard issue to recreate, but I believe is caused by how we create
datetimeandtimevalues using the Neo4j driver in the GraphQL server before sending the Cypher to the database. If the server and the database are in different timezones, I believe this can result in unexpected results. This PR aligns the creation of these values with how the@timestampdirective is resolved, by using thedatetime()function in Cypher.DateTimeandTimevalues are now created using their respective functions in Cypher, from the string values directly passed in as Cypher parameters.Complexity
Complexity: Medium
Issue
Closes #3785