fix: watch mode not working on Windows #254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I met an issue when i ran
npx hcm 'src/**/*.module.{css,scss,less}' --watch
on Windows 10. It will not generate the css file.After some debugging, I found that the callback passed to watcher in not working correctly. The flow will always early returned in
if (isExternalFile(filePath))
, and I found that the root cause of the problem is thatisMatchByGlob
insrc/util.ts
always return false. This function callminimatch
fromminimatch
.The smallest reproduce code is as follows:
I found that
minimatch
has a third argument options on its repo's README. I tried to setoptions.windowsPathsNoEscape
to true, and it works.