Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hint in delete history by ids statement. #5249

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jan 3, 2025

Summary

The missing ::uuid[] caused SQLC to generate code splicing the slice into the statement rather than passing it as-is, i.e. generating ANY(?, ?, ?, ?, ...) rather than ANY({ ... }), causing the statement compilation to fail.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Jan 3, 2025
@blkt blkt requested a review from a team as a code owner January 3, 2025 14:49
@blkt blkt changed the title Fix type hint to delete history by ids statement. Fix type hint in delete history by ids statement. Jan 3, 2025
The missing `::uuid[]` caused SQLC to generate code splicing the slice
into the statement rather than passing it as-is, i.e. generating
`ANY(?, ?, ?, ?, ...)` rather than `ANY({ ... })`, causing the
statement compilation to fail.
@blkt blkt force-pushed the fix/add-type-hint-to-delete-history-by-ids-statement branch from 2e44548 to b7bbb90 Compare January 3, 2025 14:49
@coveralls
Copy link

coveralls commented Jan 3, 2025

Coverage Status

coverage: 55.1% (-0.003%) from 55.103%
when pulling b7bbb90 on fix/add-type-hint-to-delete-history-by-ids-statement
into 04ac00a on main.

@blkt blkt merged commit a02f754 into main Jan 6, 2025
26 checks passed
@blkt blkt deleted the fix/add-type-hint-to-delete-history-by-ids-statement branch January 6, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants