Simplify internal windows-bindgen caching
#3427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
changed the title
windows-bindgen caching
|
Seems like spurious IO failures are sporadically failing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
windows-bindgencrate uses an internal static winmd reader but passing it around constantly is rather cumbersome. This simplifies this by using a staticAtomicPtrthat can be retrieved via thereaderfree function. This then helps to simplify some upcoming refactoring and bug fixing.I ended up doing the same for
Configwhich is similarly passed around and describes what and how to generate bindings from metadata.