Add backward compatibility to API in support of the new managed identity features #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
commented
Dec 27, 2024
| @@ -38,12 +48,14 @@ export async function deployWorkspaceProjectApi(deployWorkspaceProjectOptions: a | |||
| rootFolder, | |||
| srcPath: srcPath ? Uri.file(srcPath).fsPath : undefined, | |||
| dockerfilePath: dockerfilePath ? Uri.file(dockerfilePath).fsPath : undefined, | |||
| newRegistryCredentialType: RegistryCredentialType.DockerLogin, | |||
There was a problem hiding this comment.
We need additional discussions about whether we want to default to managed identity here in the future. For now, I'm keeping it as Docker Login to preserve existing behavior.
MicroFish91
commented
Dec 27, 2024
| @@ -9,7 +9,7 @@ import type * as api from "./vscode-azurecontainerapps.api"; | |||
|
|
|||
| export function getAzureContainerAppsApiProvider(): apiUtils.AzureExtensionApiProvider { | |||
| return createApiProvider([<api.AzureContainerAppsExtensionApi>{ | |||
| // Todo: Change this to 0.0.2 later. 0.0.2 is backwards compatible anyway so this change should be fine either way. | |||
| // Todo: Change this to 0.0.3 later. 0.0.3 is backwards compatible anyway so this change should be fine either way. | |||
There was a problem hiding this comment.
When we eventually add managed identity support for the api, I will bump the major version
MicroFish91
commented
Dec 27, 2024
| shouldSaveDeploySettings: !!shouldSaveDeploySettings, | ||
| }); | ||
|
|
||
| const deployWorkspaceProjectContext: DeployWorkspaceProjectContext = await deployWorkspaceProjectInternal(deployWorkspaceProjectInternalContext, { | ||
| suppressActivity: true, | ||
| suppressConfirmation, | ||
| suppressRegistryPrompt: suppressRegistryPrompt ?? true, |
There was a problem hiding this comment.
This PR introduced the prompt, so add ability to suppress and default it to true to preserve existing behavior
…e-azurecontainerapps into mwf/grim-sapphire
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #719
Updates the api consumed by functions so that it keeps working in face of all the new features we've added related to managed identities