[openssl] Fix build with "C:\Program Files\<...>\cl.exe"
#43089
+23
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the long-standing annoyance that port openssl fails to build with (some) installations of Visual Studio to paths including the space character, also affecting the default location
C:\Program Files\Visual Studio\...
.The port passes the absolute path of CC and the CFLAGS as detected from the CMake toolchain.
This works for all normal build rules, but not for the invocation of a perl scripts which is meant to write that information into
crypto/buildinf.h
which is created via this rule:mkbuildinf.pl
doesn't consider the backslash in filepaths like CC when constructing a C string.The new patch
NB the full path of the compiler is written as build information into binary aritfacts. If this isn't desired, a different approach must be taken.
Resolves #42740.
Resolves #41751.
Resolves #39912.
Resolves #38723.
Resolves #36175.
Related: