Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webui] Add new port #43052

Merged
merged 11 commits into from
Jan 7, 2025
Merged

[webui] Add new port #43052

merged 11 commits into from
Jan 7, 2025

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jan 2, 2025

CMakeLists is based on the official nmake and make configurations.

Fixes #35821

@jimwang118 jimwang118 self-assigned this Jan 2, 2025
@jimwang118 jimwang118 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 2, 2025
@JackBoosY JackBoosY marked this pull request as ready for review January 2, 2025 08:39
@jimwang118
Copy link
Contributor

All feature and usage test passed with x64-windows triplet.

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jan 3, 2025
ports/webui/vcpkg.json Outdated Show resolved Hide resolved
Copy link
Contributor

@JavierMatosD JavierMatosD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't we using upstreams build system/CMakeLists.txt?

@JavierMatosD JavierMatosD marked this pull request as draft January 3, 2025 17:32
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jan 4, 2025

Why aren't we using upstreams build system/CMakeLists.txt?

Because the official CMakeLists is only in beta version and outdated.

Additional, the official build system should be NMake and make currently.

@JackBoosY JackBoosY requested a review from JavierMatosD January 6, 2025 05:17
@JackBoosY JackBoosY marked this pull request as ready for review January 6, 2025 05:27
@JavierMatosD JavierMatosD merged commit 1faad55 into microsoft:master Jan 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] WebUI
4 participants