Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[magic-enum] Fix installation directory of CMake configurations #43032

Merged
merged 6 commits into from
Jan 7, 2025
Merged

[magic-enum] Fix installation directory of CMake configurations #43032

merged 6 commits into from
Jan 7, 2025
+9 −7

Conversation

yurybura
Copy link
Contributor

@yurybura yurybura commented Dec 31, 2024 •
edited
Loading

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@yurybura yurybura marked this pull request as ready for review December 31, 2024 13:58
WangWeiLin-MV
WangWeiLin-MV reviewed Jan 2, 2025
View reviewed changes
ports/magic-enum/portfile.cmake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the original EOL of the text file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Jan 2, 2025
@WangWeiLin-MV
Copy link
Contributor

Note: I will be converting your PR to draft status. Please click "Ready for review" after making the modifications.

@WangWeiLin-MV WangWeiLin-MV marked this pull request as draft January 3, 2025 09:54
@yurybura yurybura marked this pull request as ready for review January 4, 2025 21:06
@yurybura yurybura mentioned this pull request Jan 5, 2025
Merged
7 tasks
WangWeiLin-MV
WangWeiLin-MV approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port installation tests pass with the following triplets:

  • x64-linux

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Jan 6, 2025
@JavierMatosD JavierMatosD merged commit 3aebd5b into microsoft:master Jan 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yurybura @WangWeiLin-MV @JavierMatosD