report nice error message when dotnet is not installed #5477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| } catch (error: any) { | ||
| if (error && "code" in (error as {}) && error["code"] === "ENOENT") { | ||
| reportDiagnostic(sdkContext.program, { | ||
| code: "dependency-runtime-missing", |
There was a problem hiding this comment.
i think runtime-dependency-missing makes more sense.
Has this code been reviewed?
There was a problem hiding this comment.
update to runtime-dependency-missing. The code is for csharp-emitter only. if needed, we can review by .net arch.
archerzz
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5364
dependency-runtime-missingdiagnosticdependency-runtime-missingdiagnostic error