Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @path decorator do not accurately reflect the options parameters #5455

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Fix @path decorator do not accurately reflect the options parameters #5455

merged 6 commits into from
Jan 6, 2025

Conversation

AlitzelMendez
Copy link
Contributor

@AlitzelMendez AlitzelMendez commented Dec 27, 2024 •
edited
Loading

@AlitzelMendez AlitzelMendez marked this pull request as draft December 27, 2024 01:17
@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 27, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/rest
Show changes

@typespec/rest - fix ✏️

In some scenarios, the options for the @path decorator do not accurately reflect the provided parameters, including the #{allowReserved: true} which is the x-ms-skip-url-encoding option. This change addresses and fixes this issue.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs 🛝 VSCode Extension

@AlitzelMendez AlitzelMendez changed the title [WIP] Fix @path decorator do not accurately reflect the options parameters Fix @path decorator do not accurately reflect the options parameters Dec 27, 2024
@AlitzelMendez AlitzelMendez marked this pull request as ready for review December 27, 2024 22:22
@pshao25 pshao25 mentioned this pull request Jan 6, 2025
Open
@AlitzelMendez AlitzelMendez added this pull request to the merge queue Jan 6, 2025
Merged via the queue into microsoft:main with commit 5faa336 Jan 6, 2025
24 checks passed
@AlitzelMendez AlitzelMendez deleted the fix-set-x-ms-skip-url-encoding branch January 6, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshao25 pshao25 pshao25 approved these changes

@chrisradek chrisradek chrisradek approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlitzelMendez @azure-sdk @chrisradek @pshao25