.Net: Delete duplicative Json.ToJson #3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of this method is identical to that of Serialize. Also, one of the uses of Serialize immediately converted it to UTF8 bytes. JsonSerializer actually has to do more work to produce a string, as it first generates UTF8 and then transcodes, so we may as well just skip the intermediate string.
github-actions
bot
changed the title
markwallace-microsoft
approved these changes
Oct 16, 2023
SergeyMenshykh
approved these changes
Oct 16, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Description The implementation of this method is identical to that of Serialize. Also, one of the uses of Serialize immediately converted it to UTF8 bytes. JsonSerializer actually has to do more work to produce a string, as it first generates UTF8 and then transcodes, so we may as well just skip the intermediate string. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The implementation of this method is identical to that of Serialize.
Also, one of the uses of Serialize immediately converted it to UTF8 bytes. JsonSerializer actually has to do more work to produce a string, as it first generates UTF8 and then transcodes, so we may as well just skip the intermediate string.
Contribution Checklist