.Net: Add JsonNumberHandling Attribute to Execution Settings in Ollama, ONNX, and Other Connectors #10055
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
markwallace-microsoft
approved these changes
Jan 6, 2025
RogerBarreto
approved these changes
Jan 6, 2025
markwallace-microsoft
temporarily deployed
to
integration
GitHub Actions
Inactive
|
Thanks for contribution! @shethaadit Please add some UnitTests ensuring this works as expected. Thanks!! |
|
Hi @RogerBarreto, can we take unit test changes in next PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR addresses a deserialization issue in the
OllamaandONNXconnectors where execution settings fail to handle non-string properties (e.g., "temperature") during JSON parsing.Description
Impact:
OpenAIPromptExecutionSettings, which already includes the necessary attribute.Contribution Checklist
[Y] The code builds clean without any errors or warnings
[Y] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[Y] All unit tests pass, and I have added new tests where possible
[Y] I didn't break anyone 😄
Fixes .Net: Bug: JsonException using the Ollama and Onnx connectors #9318