Skip to content

Commit

Permalink
.Net: Bump Microsoft.CodeAnalysis.Common and Microsoft.CodeAnalysis.C…
Browse files Browse the repository at this point in the history
…Sharp in /dotnet (#9746)

Bumps [Microsoft.CodeAnalysis.Common](https://github.com/dotnet/roslyn)
and [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn).
These dependencies needed to be updated together.
Updates `Microsoft.CodeAnalysis.Common` from 4.3.0 to 4.11.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/dotnet/roslyn/releases">Microsoft.CodeAnalysis.Common's
releases</a>.</em></p>
<blockquote>
<h2>.NET 6.0.1</h2>
<p><a
href="https://github.com/dotnet/core/releases/tag/v6.0.1">Release</a></p>
<h2>.NET 5.0.4</h2>
<p><a
href="https://github.com/dotnet/core/releases/tag/v5.0.4">Release</a></p>
<h2>.NET 5.0.2</h2>
<p><a
href="https://github.com/dotnet/core/blob/master/release-notes/5.0/5.0.2/5.0.2.md">Release
Notes</a>
<a
href="https://github.com/dotnet/core/blob/master/release-notes/5.0/5.0.2/5.0.2-install-instructions.md">Install
Instructions</a></p>
<h1>Repos</h1>
<ul>
<li><a
href="https://github.com/dotnet/core/releases/tag/v5.0.2">Core</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md">Microsoft.CodeAnalysis.Common's
changelog</a>.</em></p>
<blockquote>
<h1>API Breaking Changes</h1>
<h1>Version 1.1.0</h1>
<h3>Removed VisualBasicCommandLineParser.ctor</h3>
<p>During a toolset update we noticed the constructor on
<code>VisualBasicCommandLineParser</code> was <code>public</code>. This
in turn made many of the <code>protected</code> members of
<code>CommandLineParser</code> a part of the API surface as it gave
external customers an inheritance path.</p>
<p>It was never the intent for these members to be a part of the
supported API surface. Creation of the parsers is meant to be done via
the <code>Default</code> singleton properties. There seems to be little
risk that we broke any customers here and hence we decided to remove
this API.</p>
<p>PR: <a
href="https://redirect.github.com/dotnet/roslyn/pull/4169">dotnet/roslyn#4169</a></p>
<h3>Changed Simplifier methods to throw ArgumentNullExceptions</h3>
<p>Changed Simplifier.ReduceAsync, Simplifier.ExpandAsync, and
Simplifier.Expand methods to throw ArgumentNullExceptions if any
non-optional, nullable arguments are passed in. Previously the user
would get a NullReferenceException for synchronous methods and an
AggregateException containing a NullReferenceException for asynchronous
methods.</p>
<p>PR: <a
href="https://redirect.github.com/dotnet/roslyn/pull/5144">dotnet/roslyn#5144</a></p>
<h1>Version 1.3.0</h1>
<h3>Treat a method marked with both public and private flags as
private</h3>
<p>The scenario is loading an assembly where some methods, fields or
nested types have accessibility flags set to 7 (all three bits set),
which mean public AND private.
After the fix, such flags are loaded to mean private.
The compat change is we’re trading a compile-time success and runtime
failure (native compiler) against a compile-time error (restoring the
behavior of v1.2).</p>
<p>Details below:</p>
<ul>
<li>The native compiler successfully compiles the method and field case
(those only yield runtime error System.TypeLoadException: Invalid Field
Access Flags) and reported an accessibility error on the nested
type.</li>
<li>The 1.2 compiler generated errors:</li>
</ul>
<pre><code>error BC30390: 'C.Private Overloads Sub M()' is not
accessible in this context because it is 'Private'.
error BC30389: 'C.F' is not accessible in this context because it is
'Private'.
error BC30389: 'C.C2' is not accessible in this context because it is
'Protected Friend'.
error BC30390: 'C2.Private Overloads Sub M2()' is not accessible in this
context because it is 'Private'.
</code></pre>
<ul>
<li>The 1.3 compiler crashes.</li>
<li>After fix, the same errors as 1.2 are generated again.</li>
</ul>
<p>PR: <a
href="https://redirect.github.com/dotnet/roslyn/pull/11547">dotnet/roslyn#11547</a></p>
<h3>Don't emit bad DateTimeConstant, and load bad BadTimeConstant as
default value instead</h3>
<p>The change affects compatibility in two ways:</p>
<ul>
<li>When loading an invalid DateTimeConstant(-1), the compiler will use
default(DateTime) instead, whereas the native compiler would produce
code that fails to execute.</li>
<li>DateTimeConstant(-1) will still count when we check that you don’t
specify two default values. The compiler will produce an error, instead
of succeeding (and producing IL with two attributes).</li>
</ul>
<p>PR: <a
href="https://redirect.github.com/dotnet/roslyn/pull/11536">dotnet/roslyn#11536</a></p>
<h1>Version 4.1.0</h1>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a
href="https://github.com/dotnet/roslyn/commits">compare view</a></li>
</ul>
</details>
<br />

Updates `Microsoft.CodeAnalysis.CSharp` from 4.3.0 to 4.11.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/dotnet/roslyn/releases">Microsoft.CodeAnalysis.CSharp's
releases</a>.</em></p>
<blockquote>
<h2>.NET 6.0.1</h2>
<p><a
href="https://github.com/dotnet/core/releases/tag/v6.0.1">Release</a></p>
<h2>.NET 5.0.4</h2>
<p><a
href="https://github.com/dotnet/core/releases/tag/v5.0.4">Release</a></p>
<h2>.NET 5.0.2</h2>
<p><a
href="https://github.com/dotnet/core/blob/master/release-notes/5.0/5.0.2/5.0.2.md">Release
Notes</a>
<a
href="https://github.com/dotnet/core/blob/master/release-notes/5.0/5.0.2/5.0.2-install-instructions.md">Install
Instructions</a></p>
<h1>Repos</h1>
<ul>
<li><a
href="https://github.com/dotnet/core/releases/tag/v5.0.2">Core</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md">Microsoft.CodeAnalysis.CSharp's
changelog</a>.</em></p>
<blockquote>
<h1>API Breaking Changes</h1>
<h1>Version 1.1.0</h1>
<h3>Removed VisualBasicCommandLineParser.ctor</h3>
<p>During a toolset update we noticed the constructor on
<code>VisualBasicCommandLineParser</code> was <code>public</code>. This
in turn made many of the <code>protected</code> members of
<code>CommandLineParser</code> a part of the API surface as it gave
external customers an inheritance path.</p>
<p>It was never the intent for these members to be a part of the
supported API surface. Creation of the parsers is meant to be done via
the <code>Default</code> singleton properties. There seems to be little
risk that we broke any customers here and hence we decided to remove
this API.</p>
<p>PR: <a
href="https://redirect.github.com/dotnet/roslyn/pull/4169">dotnet/roslyn#4169</a></p>
<h3>Changed Simplifier methods to throw ArgumentNullExceptions</h3>
<p>Changed Simplifier.ReduceAsync, Simplifier.ExpandAsync, and
Simplifier.Expand methods to throw ArgumentNullExceptions if any
non-optional, nullable arguments are passed in. Previously the user
would get a NullReferenceException for synchronous methods and an
AggregateException containing a NullReferenceException for asynchronous
methods.</p>
<p>PR: <a
href="https://redirect.github.com/dotnet/roslyn/pull/5144">dotnet/roslyn#5144</a></p>
<h1>Version 1.3.0</h1>
<h3>Treat a method marked with both public and private flags as
private</h3>
<p>The scenario is loading an assembly where some methods, fields or
nested types have accessibility flags set to 7 (all three bits set),
which mean public AND private.
After the fix, such flags are loaded to mean private.
The compat change is we’re trading a compile-time success and runtime
failure (native compiler) against a compile-time error (restoring the
behavior of v1.2).</p>
<p>Details below:</p>
<ul>
<li>The native compiler successfully compiles the method and field case
(those only yield runtime error System.TypeLoadException: Invalid Field
Access Flags) and reported an accessibility error on the nested
type.</li>
<li>The 1.2 compiler generated errors:</li>
</ul>
<pre><code>error BC30390: 'C.Private Overloads Sub M()' is not
accessible in this context because it is 'Private'.
error BC30389: 'C.F' is not accessible in this context because it is
'Private'.
error BC30389: 'C.C2' is not accessible in this context because it is
'Protected Friend'.
error BC30390: 'C2.Private Overloads Sub M2()' is not accessible in this
context because it is 'Private'.
</code></pre>
<ul>
<li>The 1.3 compiler crashes.</li>
<li>After fix, the same errors as 1.2 are generated again.</li>
</ul>
<p>PR: <a
href="https://redirect.github.com/dotnet/roslyn/pull/11547">dotnet/roslyn#11547</a></p>
<h3>Don't emit bad DateTimeConstant, and load bad BadTimeConstant as
default value instead</h3>
<p>The change affects compatibility in two ways:</p>
<ul>
<li>When loading an invalid DateTimeConstant(-1), the compiler will use
default(DateTime) instead, whereas the native compiler would produce
code that fails to execute.</li>
<li>DateTimeConstant(-1) will still count when we check that you don’t
specify two default values. The compiler will produce an error, instead
of succeeding (and producing IL with two attributes).</li>
</ul>
<p>PR: <a
href="https://redirect.github.com/dotnet/roslyn/pull/11536">dotnet/roslyn#11536</a></p>
<h1>Version 4.1.0</h1>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a
href="https://github.com/dotnet/roslyn/commits">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
dependabot[bot] authored Nov 19, 2024
1 parent 0d11264 commit 3a2acff
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dotnet/Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
<PackageVersion Include="Microsoft.Bcl.HashCode" Version="1.1.1" />
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
<PackageVersion Include="Microsoft.Bcl.Numerics" Version="8.0.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.3.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.3.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.11.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.11.0" />
<PackageVersion Include="Microsoft.Bcl.TimeProvider" Version="8.0.1" />
<PackageVersion Include="Microsoft.Identity.Client" Version="4.66.2" />
<PackageVersion Include="Microsoft.ML.OnnxRuntime" Version="1.19.2" />
Expand Down

0 comments on commit 3a2acff

Please sign in to comment.