Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dependency from library on expectZone, straighten csi handling #34211

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 4, 2025

No description provided.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 5, 2025

Test results for "tests 1"

3 failed
❌ [installation tests] › playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-ubuntu-latest
❌ [installation tests] › playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-ubuntu-latest
❌ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-ubuntu-latest

6 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:596:5 › launchServer › should be able to connect when the wsEndpoint is passed as an option @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/debug-controller.spec.ts:167:1 › should record @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:238:7 › cli codegen › should not target selector preview by text regexp @webkit-ubuntu-22.04-node18

37513 passed, 654 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants