Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move attachments link to step body #34196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Jan 2, 2025

Follow-up to #34037, as discussed in our review.

Before:

Screenshot 2025-01-02 at 18 38 52

After:

Screenshot 2025-01-02 at 18 24 53

(don't be spooked by the duplication in the screenshot, it's just to show how labels are spaced)

@Skn0tt Skn0tt requested review from pavelfeldman and Copilot January 2, 2025 17:39
@Skn0tt Skn0tt self-assigned this Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • packages/html-reporter/src/links.css: Language not supported

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1

5 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:356:5 › launchServer › should reject navigation when browser closes @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:219:14 › element screenshot › element screenshot should work with device scale factor @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/tracing.spec.ts:209:5 › should respect tracesDir and name @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37499 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant