Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix washed out dropdown colors in dark mode #34186

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JustasMonkev
Copy link

@JustasMonkev JustasMonkev commented Jan 1, 2025

This patch enforces a dark-mode-friendly background and text color on the dropdown elements.

previously
image
with the fix

image

image

References #33931

This patch enforces a dark-mode-friendly background and text color on the dropdown elements.
No new dependencies introduced.

References microsoft#33931

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 1, 2025

Test results for "tests 1"

7 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:343:5 › launchServer › should throw when calling waitForNavigation after disconnect @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work @smoke @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:178:3 › should exclude patterns @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18

37473 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman requested a review from agg23 January 2, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant