Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider behavior fixes #102

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Provider behavior fixes #102

merged 2 commits into from
Jan 3, 2025

Conversation

mamckee
Copy link
Collaborator

@mamckee mamckee commented Dec 6, 2024 •
edited
Loading

This PR addresses some incorrect behavior in the provider. These fixes are for behavior that isn't strictly speaking correct, but likely won't cause real-world issues.

  • Check that ECDSA signature is a sequence of two integers without trailing data
  • Return authenticated bytes for AEAD ciphers if out is NULL

@mamckee mamckee merged commit a8e9f21 into main Jan 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-lee-msft samuel-lee-msft samuel-lee-msft approved these changes

@ccalik ccalik Awaiting requested review from ccalik

@mlindgren mlindgren Awaiting requested review from mlindgren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamckee @samuel-lee-msft