PBKDF2 #101
Open
PBKDF2 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (ctx == NULL) | ||
| return; | ||
|
|
||
| SymCryptWipeKnownSize(&ctx->expandedKey, sizeof(SYMCRYPT_SRTPKDF_EXPANDED_KEY)); |
| #endif | ||
|
|
||
| // Constants defined SP800-132 that should be checked | ||
| // unless the OSSL_KDF_PARAM_PKCS5 paremeter gets set |
| { | ||
| ctx->libctx = provctx->libctx; | ||
| ctx->pMac = SymCryptHmacSha1Algorithm; | ||
| ctx->iterationCount = PKCS5_DEFAULT_ITER; |
| ctx->libctx = provctx->libctx; | ||
| ctx->pMac = SymCryptHmacSha1Algorithm; | ||
| ctx->iterationCount = PKCS5_DEFAULT_ITER; | ||
| ctx->checkMinSizes = TRUE; |
| else | ||
| { | ||
| copyCtx->initialized = FALSE; | ||
| } |
There was a problem hiding this comment.
This seems a little weird to me; when we set password / mac in p_scossl_pbkdf2_set_ctx_params, we explicitly do not eagerly initialize expandedKey, but wait until the next call to p_scossl_pbkdf2_derive.
This logic seems to eagerly expand the key in the destination context even if it may not yet be expanded in the source context; which just seems overcomplex vs. always setting copyCtx->initialized = FALSE?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds PBKDF2 and associated tests to the SymCrypt provider.