Unifying Remove function with PA #2776
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderson-joyle
force-pushed
the
andersonf/unify/remove-function
branch
from
65b5f6c to
5e675d8
Compare
|
✅ No public API change. #Resolved |
3 similar comments
|
✅ No public API change. #Resolved |
|
✅ No public API change. #Resolved |
|
✅ No public API change. #Resolved |
anderson-joyle
force-pushed
the
andersonf/unify/remove-function
branch
from
4619d74 to
8983927
Compare
|
✅ No public API change. #Resolved |
1 similar comment
|
✅ No public API change. #Resolved |
anderson-joyle
force-pushed
the
andersonf/unify/remove-function
branch
from
9dbde75 to
617a7fd
Compare
|
✅ No public API change. #Resolved |
2 similar comments
|
✅ No public API change. #Resolved |
|
✅ No public API change. #Resolved |
…d (value) multiple times.
anderson-joyle
force-pushed
the
andersonf/unify/remove-function
branch
from
4ea55b9 to
42a16ef
Compare
|
✅ No public API change. #Resolved |
|
✅ No public API change. #Resolved |
MikeStall
reviewed
Jan 2, 2025
src/libraries/Microsoft.PowerFx.Core/Public/Values/CollectionTableValue.cs
Outdated
Show resolved
Hide resolved
MikeStall
reviewed
Jan 2, 2025
| { | ||
| return errorRecord.Error; | ||
| } | ||
| } |
There was a problem hiding this comment.
we should discuss this.
This is eagerly scanning the entire table. Can we confirm that's the language semantics?
The danger is:
- that could be a lot of work upfront
- that could prevent future optimizations
- in paging/delegation cases, we don't download entire table . It could be a random set of rows. If there are error rows, they may or may not show up in that random set.
|
✅ No public API change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.