make sure not to call IsSubpathOf on rootpaths that are null like in … #8069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the interactive window case
|
rchiodo
approved these changes
Nov 14, 2024
StellaHuang95
approved these changes
Nov 14, 2024
AdamYoblick
reviewed
Nov 14, 2024
| @@ -524,7 +524,7 @@ private void WatchedFilesRegistered(object sender, DidChangeWatchedFilesRegistra | |||
| private void UpdateInterpreterExcludes() { | |||
| this._clientContexts.ForEach(context => { | |||
|
|
|||
| if (PathUtils.IsSubpathOf(context.RootPath, context.InterpreterConfiguration.InterpreterPath)) { | |||
| if (context.RootPath != null && PathUtils.IsSubpathOf(context.RootPath, context.InterpreterConfiguration.InterpreterPath)) { | |||
There was a problem hiding this comment.
Another option here which might be cleaner is to have PathUtils.IsSubpathOf() do a null check for both of these inputs, and just return false if either one is null or empty. But this is fine too 😄
AdamYoblick
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the interactive window case