Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(telemetry-utlis): Make MockLogger internal #23473

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Jan 6, 2025

Description

Warning

This is intended to go into the 2.20 release because it includes breaking changes to the legacy+alpha API surface (tracking issue: #23039). Do not merge it before that.

Removes the MockLogger class from the @alpha+@legacy API surface. It has been deprecated for external use since 2024-06-18.

Note: originally merged in #23010 and reverted in #23035 because it hadn't been announced previously as part of the breaking changes in 2.10.

Breaking Changes

  • MockLogger is now removed from the @alpha+@legacy API surface, becoming only @internal.

Reviewer Guidance

The review process is outlined on this wiki page.

AB#22886

@Copilot Copilot bot review requested due to automatic review settings January 6, 2025 22:03
@alexvy86 alexvy86 requested review from a team as code owners January 6, 2025 22:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@alexvy86 alexvy86 requested a review from a team January 6, 2025 22:03
@alexvy86 alexvy86 linked an issue Jan 6, 2025 that may be closed by this pull request
@github-actions github-actions bot added changeset-present public api change Changes to a public API base: main PRs targeted against main branch labels Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170492 links
    1603 destination URLs
    1838 URLs ignored
       0 warnings
       0 errors


@alexvy86 alexvy86 merged commit 237f042 into microsoft:main Jan 7, 2025
38 checks passed
@alexvy86 alexvy86 deleted the make-mock-logger-internal branch January 7, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove MockLogger from public API surface
3 participants