-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[For 2.20] Remove IContainerRuntimeOptions.flushmode #23337
[For 2.20] Remove IContainerRuntimeOptions.flushmode #23337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 46abe82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor tweaks to wording, but docs look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would also be okay to point to deprecation release notes (when available)
@jason-ha what specifically are you suggesting? |
Co-authored-by: jzaffiro <[email protected]>
f068b4a
to
646135f
Compare
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
Description
Fixes AB#26496
See #23287
IContainerRuntimeOptions.flushMode
is removed. See https://github.com/microsoft/FluidFramework/releases/tag/client_v2.12.0#user-content-icontainerruntimeoptionsflushmode-is-now-deprecated-23288Breaking Changes
This is a breaking change to the
IContainerRuntimeOptions
interface.flushMode
is deprecated as of2.12.0
, and there are no known usages in partner codebases.FlushMode.Immediate
has been deprecated since2.0.0-rc.2.0.0
.