-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update info for svg <script>
element
#37529
base: main
Are you sure you want to change the base?
Conversation
Preview URLs (comment last updated: 2025-01-07 17:18:10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skyclouds2001 I've included a couple of comments. I'm not an expert on SVG, so let's see if @pepelsbey has any thoughts too.
files/jsondata/SVGData.json
Outdated
"'type'", | ||
"'href'", | ||
"'crossorigin'", | ||
"'xlink:href'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec doesn't explicitly list this as an attribute option. Is this part of "xLinkAttributes"
, which I'm assuming represents deprecated xlink attributes
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this should also be removed as it is represented in xLinkAttributes!
- {{SVGAttr("href")}} | ||
- : The {{Glossary("URL")}} to the script to load. | ||
_Value type_: **[\<URL>](/en-US/docs/Web/SVG/Content_type#url)** ; _Default value_: _none_; _Animatable_: **no** | ||
- {{SVGAttr("type")}} | ||
- : This attribute defines type of the script language to use. | ||
_Value type_: [**\<string>**](/en-US/docs/Web/CSS/string); _Default value_: `application/ecmascript`; _Animatable_: **no** | ||
_Value type_: [**`<media-type>`**](/en-US/docs/Glossary/MIME_type); _Default value_: `application/ecmascript`; _Animatable_: **no** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know MIME types are otherwise known as IANA media types, but I would suggest making the link text "MIME type", because "media type" is more commonly associated with media queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is suggested by @hamishwillee in #37288 (comment), and the MIME type glossary says it can be said as media type, which spec is also the same
Description
Motivation
Additional details
https://svgwg.org/svg2-draft/interact.html#ScriptElement for spec
Related issues and pull requests