Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Paint Timing pages #22771

Merged
merged 5 commits into from
Dec 7, 2022
Merged

Update Paint Timing pages #22771

merged 5 commits into from
Dec 7, 2022

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Dec 6, 2022

Description

This PR updates https://developer.mozilla.org/en-US/docs/Web/API/PerformancePaintTiming and redirects https://developer.mozilla.org/en-US/docs/Web/API/Paint_Timing_API to it.

Motivation

openwebdocs/project#62

Additional details

The Paint_Timing_API overview page doesn't bring any additional value. We discussed that we want to present the Performance API as a single API and not fragment it per the individual specifications anymore. A Performance API guide will present all of these things together.

Related issues and pull requests

See also #22031 where the groups were reduced to a single "Performance API" group already.

@Elchi3 Elchi3 requested review from a team as code owners December 6, 2022 15:17
@Elchi3 Elchi3 requested review from wbamberg and bsmth and removed request for a team December 6, 2022 15:17
@github-actions github-actions bot added Content:Glossary Glossary entries Content:WebAPI Web API docs labels Dec 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Preview URLs

Flaws (1)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/PerformancePaintTiming
Title: PerformancePaintTiming
Flaw count: 1

  • macros:
    • /en-US/docs/Glossary/Largest_contentful_paint does not exist

(comment last updated: 2022-12-07 15:00:01)

@bsmth
Copy link
Member

bsmth commented Dec 7, 2022

Thanks, Florian, taking a look 👀

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments / minor suggestions, but otherwise looks good, tnx 👍🏻

Co-authored-by: Brian Thomas Smith <[email protected]>
@bsmth
Copy link
Member

bsmth commented Dec 7, 2022

Thanks, I think this is ready to go, I will merge shortly

@bsmth bsmth merged commit 1192b13 into mdn:main Dec 7, 2022
@Elchi3 Elchi3 deleted the paint-timing branch December 7, 2022 15:02
wbamberg added a commit to wbamberg/content that referenced this pull request Dec 8, 2022
* upstream/main: (286 commits)
  Correct Epsilon property description (mdn#22804)
  Fix typo in subtle crypto digest (mdn#22802)
  Alt tag added - reference issue mdn#21616 (mdn#22255)
  WeakSet: Improve recursive validation example (mdn#22787)
  New page: validityState.valueMissing (mdn#22691)
  Edit: <dialog> element (mdn#22786)
  Update Paint Timing pages (mdn#22771)
  chore(deps): bump @mdn/yari from 1.27.16 to 1.27.20 (mdn#22791)
  chore(deps): bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (mdn#22790)
  Remove WebGLSidebar (mdn#22782)
  fix indefinite articles usage (mdn#22789)
  Removed part of sentence that refers to code that appears to have been removed (mdn#22788)
  Split (Async)?(Generator)?Function class and ctor pages (mdn#22778)
  Fix interfaces links (mdn#22779)
  Change "hypertext link" to "hypertext links" (mdn#22780)
  add hyphenate-limit-chars CSS property (mdn#22747)
  22225: Add links to accessibility guides section (mdn#22240)
  ci(markdownlint): use GitHub API to get changed files (mdn#22773)
  Document font-palette & @font-palette-values with its descriptors (mdn#22519)
  fix typo in createImageBitmap api (mdn#22774)
  ...
hamishwillee pushed a commit to hamishwillee/content that referenced this pull request Dec 12, 2022
* Improve PerformancePaintTiming

* Delete and redirect overview page

* FP is optional (seems Safari doesn't show it)

* Apply suggestions from code review

Co-authored-by: Brian Thomas Smith <[email protected]>

Co-authored-by: Brian Thomas Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants