Rewrite Using the User Timing API #21917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs (this comment was updated 2022-10-31 08:33:16.738728) |
teoli2003
suggested changes
Oct 31, 2022
files/en-us/web/api/user_timing_api/using_the_user_timing_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/user_timing_api/using_the_user_timing_api/index.md
Outdated
Show resolved
Hide resolved
|
|
||
| A _live_ version of the examples is available on [GitHub](https://mdn.github.io/dom-examples/performance-apis/Using_the_User_Timing_API.html), as is the [source code](https://github.com/mdn/dom-examples/blob/main/performance-apis/Using_the_User_Timing_API.html). Pull requests, enhancement requests and [bug reports](https://github.com/mdn/dom-examples/issues) are welcome. | ||
| ## What is User Timing? |
There was a problem hiding this comment.
Suggested change
| ## What is User Timing? | |
| ## What is a user timing? |
There was a problem hiding this comment.
I think "User Timing" is better. It refers to the name of the API.
files/en-us/web/api/user_timing_api/using_the_user_timing_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/user_timing_api/using_the_user_timing_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/user_timing_api/using_the_user_timing_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/user_timing_api/using_the_user_timing_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/user_timing_api/using_the_user_timing_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/user_timing_api/using_the_user_timing_api/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/user_timing_api/using_the_user_timing_api/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jean-Yves Perrier <[email protected]>
…index.md Co-authored-by: Jean-Yves Perrier <[email protected]>
|
Thanks for the review, @teoli2003! I fixed the flaw and applied all but one of your suggestions :) |
teoli2003
approved these changes
Oct 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rewrites https://developer.mozilla.org/en-US/docs/Web/API/User_Timing_API/Using_the_User_Timing_API.
Motivation
openwebdocs/project#62
Additional details
I ended up completely rewriting this page. I don't think its current structure nor the code examples are particularly useful. It also references stuff on GitHub which I think should be removed. https://github.com/mdn/dom-examples/blob/main/performance-apis/
Related issues and pull requests
#21853 rewrites the corresponding overview page for this API.