Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose goal sum metrics added to reports via EnrichRecordWithGoalMetricSums to report metadata. #22272

Open
wants to merge 11 commits into
base: 5.x-dev
Choose a base branch
from
Open

Expose goal sum metrics added to reports via EnrichRecordWithGoalMetricSums to report metadata. #22272

wants to merge 11 commits into from

Conversation

diosmosis
Copy link
Member

Description:

Refs matomo-org/looker-studio-connector#62

As title. This PR allows API consumers that depend on report metadata to use the overall nb_conversions and revenue metrics added to some reports that use EnrichRecordWithGoalMetricSums during archiving.

Review

@diosmosis diosmosis mentioned this pull request Jun 1, 2024
Draft
11 tasks
@diosmosis diosmosis force-pushed the missing-processed-report-metrics branch from 5113efa to bce3b72 Compare June 1, 2024 19:44
@michalkleiner
Copy link
Contributor

Not sure if this is ready for review as the label hasn't been added yet. There are some UI tests that need updating with the new metrics as well.

@diosmosis diosmosis marked this pull request as draft June 2, 2024 12:45
diosmosis added 3 commits June 3, 2024 10:47
@diosmosis
update expected screenshots
aa369e2
@diosmosis
update expected screenshot
6cf6e7d
@diosmosis
allow reports to specify that they have goal specific metrics (for so…
b4d1125 
…me or all goals), but not the overall goal sum metrics provided by EnrichRecordWithGoalMetricSums
@diosmosis diosmosis force-pushed the missing-processed-report-metrics branch from 2067dcd to b4d1125 Compare June 3, 2024 21:07
@diosmosis diosmosis marked this pull request as ready for review June 3, 2024 22:09
@diosmosis diosmosis added the Needs Review PRs that need a code review label Jun 3, 2024
@diosmosis
Copy link
Member Author

Should be ready for review now.

@github-actions GitHub Actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jun 11, 2024
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jun 11, 2024
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jun 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 6, 2024

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jul 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Sep 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Sep 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Nov 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diosmosis @michalkleiner