Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useCustomerWishlistSkus infinite loop #4370

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

joseamietta
Copy link

Description

Remove hook useCustomerWishlistSkus from useCarousel and useGallery and add in useApp to avoid infinite loop

Related Issue

Closes #4365.

…nts and add in useApp talon to avoid infinite loop
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jan 3, 2025

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/venia-ui/lib/components/App/__tests__/app.spec.js
🚫 Missing "Verification Steps" section. Please add it back, with detail.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against f9035e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Infinite loop query GetWishlistItemsForLocalField
2 participants