Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hapi.js starter template #189

Merged
merged 12 commits into from
Dec 5, 2020

Conversation

TheSTL
Copy link
Contributor

@TheSTL TheSTL commented Oct 5, 2020

What kind of change does this PR introduce?
Feature: Support Hapi.js Nodejs framework (Except for Graphql template).

Did you add tests for your changes?
Yes.
If relevant, did you update the documentation?
No
Summary

Support Hapi.js Nodejs framework (except for Graphql template).

Addresses #66

Does this PR introduce a breaking change?
No

Other information

@welcome
Copy link

welcome bot commented Oct 5, 2020

Thanks for opening this pull request! Please check out our contributing guidelines.

@jamesgeorge007 jamesgeorge007 added feature New feature Hacktoberfest Valid for Hacktoberfest-2020 labels Oct 12, 2020
@jamesgeorge007 jamesgeorge007 changed the title Hapi feat: Hapi.js starter template Oct 12, 2020
@TheSTL
Copy link
Contributor Author

TheSTL commented Nov 2, 2020

@jamesgeorge007 You can review this PR.

@TheSTL
Copy link
Contributor Author

TheSTL commented Nov 7, 2020

@jamesgeorge007 Please review again.

Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; can you also address the case when the user needs to generate a CRUD boilerplate with the generate command?

@jamesgeorge007 jamesgeorge007 changed the base branch from develop to feat/starter-templates November 21, 2020 11:49
@TheSTL
Copy link
Contributor Author

TheSTL commented Nov 30, 2020

Done with mevn-generate command changes for hapi @jamesgeorge007

@jamesgeorge007 jamesgeorge007 merged commit b78f74d into madlabsinc:feat/starter-templates Dec 5, 2020
@welcome
Copy link

welcome bot commented Dec 5, 2020

congrats
Congrats on your very first contribution 👏 Looking forward to having more from your side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature Hacktoberfest Valid for Hacktoberfest-2020
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants