[ONNX] clarifies error message for upsample interpolation mode #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- easier to find - cleaner diffs when modified
bjacobgordon
force-pushed
the
fix-onnx-clarifies-upsample-interpolation-mode-error-message
branch
from
ba53bcd to
13bbe6b
Compare
zjgarvey
reviewed
Jan 3, 2025
- prior error message felt more like an implementation stub than an assertion failure
- prior error message did not communicate input type - grepping the neighboring literals wouldn't also grep these instances
bjacobgordon
force-pushed
the
fix-onnx-clarifies-upsample-interpolation-mode-error-message
branch
from
13bbe6b to
803c266
Compare
bjacobgordon
commented
Jan 3, 2025
zjgarvey
approved these changes
Jan 6, 2025
bjacobgordon
deleted the
fix-onnx-clarifies-upsample-interpolation-mode-error-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zjgarvey How's it look?