-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMDGPU][Offload] Adds RHEL 8 CMake cache file builder #349
base: main
Are you sure you want to change the base?
Conversation
Does the build directory be unique across the fleet of builders? |
This is from a worker we have that is used for 4 different builders:
There is only one builder that builds in a folder called If the build folder was more generic like "build-llvm" then in theory as long as two differently configured builders never landed on the same worker, there would be no problem. It's easy to name the folder uniquely though, so I'd do it anyway. And it provides you a clue if, for example, your disk fills up because of one specific builder. With unique build folder names you can tell which one did it from looking at the worker machine. If only one builder runs on that machine, this isn't an advantage. |
If the distinction between "builder" and "worker" isn't clear (it never has been :) ), slide 5 of https://llvm.org/devmtg/2022-11/slides/TechTalk5-WhatDoesItTakeToRunLLVMBuildbots.pdf tries to clarify. More often than not in LLVM's bots we have a specific worker (or set of) for each builder, so it can seem like builder and worker are the same thing, but it does not have to be done that way. In your case you need a specific OS installed so a specific worker is a good way to ensure that. |
Actually Buildbot does seem to enforce unique build dirs, from the CI result:
Perhaps a bit pessimistic but I can see why they'd do that. |
Thank you for that elaborate answer. I did understand that there is a difference, however, so far, we have always had a 1:1 mapping. |
5b4f0f6
to
6e91448
Compare
I put in a unique builddir and a custom |
No description provided.