New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower neon_vmaxvq_u8,neon_vmaxvq_s8, neon_vmaxv_u8 and neon_vmaxvq_s8 #1265

Open

ghehg wants to merge 1 commit into llvm:main from ghehg:neon64

Collaborator

ghehg commented Jan 3, 2025 •

edited

Loading

Neon definiton
OG implementation
Implementation in this PR is different from OG as

avoided code duplication by extracting out the common pattern
avoided using i32 as return type of the intrinsic call, so eliminated the need for casting result of the intrinsic call. This way of OG's implementation is quite unnecessary IMHO, this is MAX, not ADD or MUL. After all, using the expected type as return type of intrinsic call produces the same ASM code.


          Lower neon_vmaxvq_u8,neon_vmaxvq_s8, neon_vmaxv_u8 and neon_vmaxvq_s8

6d1985e

ghehg marked this pull request as ready for review

January 3, 2025 15:30

ghehg requested review from lanza and bcardosolopes as code owners

January 3, 2025 15:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet