Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CIRGen][Builtin][Neon] Lower vaddh_f16, vsubh_f16, vmulh_f16 and vdivh_f16 #1258

Merged
merged 2 commits into from
Jan 6, 2025
Merged

[CIR][CIRGen][Builtin][Neon] Lower vaddh_f16, vsubh_f16, vmulh_f16 and vdivh_f16 #1258

merged 2 commits into from
Jan 6, 2025
+713 −8

Conversation

AmrDeveloper
Copy link
Member

Lowering:

  • vaddh_f16
  • vsubh_f16
  • vmulh_f16
  • vdivh_f16

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

ghehg
ghehg requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@ghehg ghehg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a minor suggestion of change to the test.

@AmrDeveloper AmrDeveloper requested a review from ghehg January 2, 2025 17:20
@bcardosolopes bcardosolopes merged commit a36829f into llvm:main Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghehg ghehg ghehg approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

@bcardosolopes bcardosolopes Awaiting requested review from bcardosolopes bcardosolopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmrDeveloper @ghehg @bcardosolopes